[webkit-reviews] review granted: [Bug 133683] Inline caching should try to flatten uncacheable dictionaries : [Attachment 232793] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 133683: Inline caching should try to flatten uncacheable dictionaries
https://bugs.webkit.org/show_bug.cgi?id=133683

Attachment 232793: Patch
https://bugs.webkit.org/attachment.cgi?id=232793&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=232793&action=review


r=me

> Source/JavaScriptCore/jit/Repatch.cpp:727
> +    if (structure->isUncacheableDictionary() &&
!structure->hasBeenFlattenedBefore())
> +	   asObject(baseCell)->flattenDictionaryObject(*vm);

I think this line should precede the "Optimize self access" paragraph. If
flattening works, there's no need to resort to building a polymorphic list
right away.