[webkit-reviews] review denied: [Bug 133546] [JavaScriptCore] FTL buildfix for EFL platform : [Attachment 232547] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 10 09:32:17 PDT 2014

Filip Pizlo <fpizlo at apple.com> has denied László Langó
<llango.u-szeged at partner.samsung.com>'s request for review:
Bug 133546: [JavaScriptCore] FTL buildfix for EFL platform

Attachment 232547: Patch

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=232547&action=review

> Source/JavaScriptCore/ftl/FTLLocation.cpp:64
> +    return loc;

It would be far better to just say "return Location();"

> Source/JavaScriptCore/llvm/InitializeLLVMPOSIX.cpp:66
> +#pragma GCC diagnostic ignored "-Wmissing-format-attribute"


More information about the webkit-reviews mailing list