[webkit-reviews] review denied: [Bug 133664] [iOS] Clear UIProcess visual state after WebProcess crash : [Attachment 232747] patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has denied Martin Hock
<mhock at apple.com>'s request for review:
Bug 133664: [iOS] Clear UIProcess visual state after WebProcess crash
https://bugs.webkit.org/show_bug.cgi?id=133664

Attachment 232747: patch
https://bugs.webkit.org/attachment.cgi?id=232747&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=232747&action=review


> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:641
> +    _overridesMinimumLayoutSize = NO;
> +    _minimumLayoutSizeOverride = {0, 0};
> +    _overridesMinimumLayoutSizeForMinimalUI = NO;
> +    _minimumLayoutSizeOverrideForMinimalUI = {0, 0};
> +    _overridesMaximumUnobscuredSize = NO;
> +    _maximumUnobscuredSizeOverride = {0, 0};
> +    _usesMinimalUI = NO;
> +    _needsToNotifyDelegateAboutMinimalUI = NO;
> +    _inputViewBounds = {{0, 0}, {0, 0}};

Most of those are defined by external factors, they should not be reset on
crash!

> Source/WebKit2/UIProcess/mac/RemoteLayerTreeHost.mm:147
> +    for (auto& idLayer : m_layers) {
> +	   m_animationDelegates.remove(idLayer.key);
> +	   asLayer(idLayer.value.get()).contents = nullptr;
> +    }

Shouldn't we remove the sublayers before clearing the root?