[webkit-reviews] review granted: [Bug 133665] Work towards having frames in the scrolling tree : [Attachment 232750] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 9 17:20:14 PDT 2014


Tim Horton <thorton at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 133665: Work towards having frames in the scrolling tree
https://bugs.webkit.org/show_bug.cgi?id=133665

Attachment 232750: Patch
https://bugs.webkit.org/attachment.cgi?id=232750&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=232750&action=review


> Source/WebCore/rendering/RenderLayerCompositor.cpp:3611
> +    RenderElement* frameRenderer = ownerElement ? ownerElement->renderer() :
0;

nullptr

> Source/WebCore/rendering/RenderView.cpp:842
> +    // FIXME: view() is just *this here.

why the fixme instead of fixing?


More information about the webkit-reviews mailing list