[webkit-reviews] review granted: [Bug 133645] Add -[WKWebView loadHTMLString:baseURL:] : [Attachment 232715] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 9 11:06:25 PDT 2014


Sam Weinig <sam at webkit.org> has granted Anders Carlsson <andersca at apple.com>'s
request for review:
Bug 133645: Add -[WKWebView loadHTMLString:baseURL:]
https://bugs.webkit.org/show_bug.cgi?id=133645

Attachment 232715: Patch
https://bugs.webkit.org/attachment.cgi?id=232715&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=232715&action=review


> Source/WebKit2/UIProcess/WebPageProxy.cpp:758
> +    m_pageLoadState.setPendingAPIRequestURL(transaction, String());

This should match whatever we show as the URL. In this case, about:blank if
there is no baseURL and the baseURL otherwise.


More information about the webkit-reviews mailing list