[webkit-reviews] review granted: [Bug 133619] [Mac] checkboxes and radio buttons animate incorrectly : [Attachment 232685] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Dean Jackson <dino at apple.com>'s request
for review:
Bug 133619: [Mac] checkboxes and radio buttons animate incorrectly
https://bugs.webkit.org/show_bug.cgi?id=133619

Attachment 232685: Patch
https://bugs.webkit.org/attachment.cgi?id=232685&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=232685&action=review


> Source/WebCore/platform/mac/ThemeMac.mm:304
> +static const std::array<FloatSize, 3>& checkboxOffsets()

I think this could use a comment explaining what they the offsets are used for.


> Source/WebCore/platform/mac/ThemeMac.mm:332
> +static const std::array<FloatSize, 3>& radioOffsets()

I think this could use a comment explaining what they the offsets are used for.