[webkit-reviews] review granted: [Bug 133612] Regression r168397 - Form layout is incorrect on OS X Yosemite : [Attachment 232671] Patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Dean Jackson
<dino at apple.com>'s request for review:
Bug 133612: Regression r168397 - Form layout is incorrect on OS X Yosemite
https://bugs.webkit.org/show_bug.cgi?id=133612

Attachment 232671: Patch
https://bugs.webkit.org/attachment.cgi?id=232671&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=232671&action=review


> Source/WebCore/platform/graphics/mac/GraphicsContextMac.mm:71
> +    return wkDrawFocusRingAtTime(context, DBL_MAX);

Please use std::numeric_limits<double>::max() here.

> Source/WebCore/platform/mac/ThemeMac.mm:379
> +    wkDrawCellFocusRingWithFrameAtTime(cell, cellFrame, controlView,
DBL_MAX);

Same thing here.

> Source/WebCore/rendering/RenderThemeMac.mm:928
> +	   if (wkDrawCellFocusRingWithFrameAtTime(popupButton, inflatedRect,
view, DBL_MAX))

And here.