[webkit-reviews] review granted: [Bug 133590] Automatic text track selection can select more than one track : [Attachment 232637] Proposed patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 6 17:20:35 PDT 2014


Brent Fulgham <bfulgham at webkit.org> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 133590: Automatic text track selection can select more than one track
https://bugs.webkit.org/show_bug.cgi?id=133590

Attachment 232637: Proposed patch.
https://bugs.webkit.org/attachment.cgi?id=232637&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=232637&action=review


r=me

> Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp:774
> +	   if (kind != TextTrack::captionsKeyword() && kind !=
TextTrack::descriptionsKeyword() && kind != TextTrack::subtitlesKeyword())

This pattern gets used in a few places. Someday we should make some kind of
"TextTrack::shouldDisplayKind(kind)" or something.


More information about the webkit-reviews mailing list