[webkit-reviews] review denied: [Bug 133562] Add SPI for Injected Bundle to provide user agent for a given URL : [Attachment 232622] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has denied Grant Kennell <gkennell at apple.com>'s
request for review:
Bug 133562: Add SPI for Injected Bundle to provide user agent for a given URL
https://bugs.webkit.org/show_bug.cgi?id=133562

Attachment 232622: Patch
https://bugs.webkit.org/attachment.cgi?id=232622&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=232622&action=review


> Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:102

> +    WKStringRef userAgentForURL(WKBundleFrameRef frame, WKStringRef url);

This should take a WebFrame* and API::String* and return an API::String*

> Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:85
>  #include <WebCore/Widget.h>
>  #include <WebCore/WindowFeatures.h>
>  #include <wtf/NeverDestroyed.h>
> +#include "WKBundleAPICast.h"

Needs sorting.

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2270
> +String WebPage::userAgent(WKBundleFrameRef frame, const URL& url) const

This should take a WebFrame*

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2273
> +	   RefPtr<API::String> urlString = API::String::create(url.string());

This should be a RefPtr<API::URL>

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2281
> +    }
> +    else {
> +	   return m_userAgent;
> +    }
> +}

No need for the else block here.