[webkit-reviews] review denied: [Bug 133571] [JavaScriptCore] Fix FTL on platform EFL. : [Attachment 232611] Patch

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has denied László Langó
<llango.u-szeged at partner.samsung.com>'s request for review:
Bug 133571: [JavaScriptCore] Fix FTL on platform EFL.
https://bugs.webkit.org/show_bug.cgi?id=133571

Attachment 232611: Patch
https://bugs.webkit.org/attachment.cgi?id=232611&action=review

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=232611&action=review


You appear to have lifted this code, without attribution, from
https://llvm.org/svn/llvm-project/libcxxabi/trunk/src/Unwind/AddressSpace.hpp. 
That's not cool, man.  In particular, the LLVM license clearly states that
LLVM's copyright notice must be preserved, and you have failed to do that.

> Source/JavaScriptCore/ftl/FTLUnwindInfo.cpp:234
> +typedef uintptr_t intPtr;

Why?