[webkit-reviews] review granted: [Bug 133459] REGRESSION(169440): Repro crash when playing a video with captions : [Attachment 232595] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 5 21:43:18 PDT 2014


Eric Carlson <eric.carlson at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 133459: REGRESSION(169440): Repro crash when playing a video with captions
https://bugs.webkit.org/show_bug.cgi?id=133459

Attachment 232595: Patch
https://bugs.webkit.org/attachment.cgi?id=232595&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=232595&action=review


>
Source/WebCore/platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:405

> +		       LOG(Media, "InbandTextTrackPrivateAVF::processCue(%p) -
found an extension cue for time = %.2f, position =  %.2f, line =  %.2f", this,
arrivingCue->startTime(), arrivingCue->position(), arrivingCue->line());

Won't this log about every cue regardless of whether or not it extends a cue?


More information about the webkit-reviews mailing list