[webkit-reviews] review granted: [Bug 133521] iOS8 media controls look different from iOS7 media controls : [Attachment 232589] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 133521: iOS8 media controls look different from iOS7 media controls
https://bugs.webkit.org/show_bug.cgi?id=133521

Attachment 232589: Patch
https://bugs.webkit.org/attachment.cgi?id=232589&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=232589&action=review


> Source/WebCore/Modules/mediacontrols/mediaControlsiOS.css:26
> +    min-width: 260px;

Nit: odd spacing, is there a tab in here?

> LayoutTests/platform/ios-sim/media/audio-width.html:30
> +	       console.log("testing...");

console.log() doesn't end up in the results.

> LayoutTests/platform/ios-sim/media/audio-width.html:33
> +	       var audioPath = "../../../media/" + findMediaFile("audio",
"content/test");

But: I think you can include the "../../" in the path passed to findMediaFile.

> LayoutTests/platform/ios-sim/media/audio-width.html:36
> +	       runTest();

Nit: this doesn't necessarily have to be a separate function.