[webkit-reviews] review granted: [Bug 133530] [iOS][WK2] Add device orientation : [Attachment 232518] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 5 13:27:31 PDT 2014

Tim Horton <thorton at apple.com> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 133530: [iOS][WK2] Add device orientation

Attachment 232518: Patch

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=232518&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:193
> +	   return 0;

sad that we don't have a comparable enum and use integer degrees instead, but
not your fault

> Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm:287
> +    if (deviceOrientation != m_deviceOrientation) {

This (and possibly those above) needs to check isValid, I think? (what happens
if the WebProcess is dead when we get a UIWindowDidRotateNotification?)

More information about the webkit-reviews mailing list