[webkit-reviews] review denied: [Bug 131515] [ftlopt] Inlining native functions into the JavaScript in the FTL : [Attachment 232509] Native runtime library inlining in FTL for ftlopt branch

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has denied Matthew Mirman <mmirman at apple.com>'s
request for review:
Bug 131515: [ftlopt] Inlining native functions into the JavaScript in the FTL
https://bugs.webkit.org/show_bug.cgi?id=131515

Attachment 232509: Native runtime library inlining in FTL for ftlopt branch
https://bugs.webkit.org/attachment.cgi?id=232509&action=review

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
One more bug to fix: InlineRuntimeSymbolTable.h should go do the build
directory instead of being placed in the source directory.

It's OK to have InlineRuntimeSymbolTable.h in the source directory if it's
checked into the repository and the build system never modifies it.

It's OK to have InlineRuntimeSymbolTable.h generated by the build system if
it's in the build directory.

Right now, you're generating it with the build system, you're not checking it
in (so far so good), but you're placing it into the source directory (bad).

Otherwise this is starting to look quite good!