[webkit-reviews] review granted: [Bug 131240] [Bindings] "nullable" sequence<T> support is incomplete : [Attachment 232133] simpler patch (2) - with WebSocket.idl changes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 4 15:20:07 PDT 2014


Darin Adler <darin at apple.com> has granted Antonio Gomes
<tonikitoo at webkit.org>'s request for review:
Bug 131240: [Bindings] "nullable" sequence<T> support is incomplete
https://bugs.webkit.org/show_bug.cgi?id=131240

Attachment 232133: simpler patch (2) - with WebSocket.idl changes
https://bugs.webkit.org/attachment.cgi?id=232133&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=232133&action=review


> Source/WebCore/bindings/scripts/test/TestObj.idl:212
> +    void    methodWithAndWithoutNullableSequence(sequence<unsigned long>
arrayArg, sequence<unsigned long>? nullableArrayArg);
> +    void    methodWithAndWithoutNullableSequence2(unsigned long[] arrayArg,
unsigned long[]? nullableArrayArg);

Should not have four spaces after "void".


More information about the webkit-reviews mailing list