[webkit-reviews] review granted: [Bug 133503] Enable WebGL on Windows : [Attachment 232467] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 4 14:48:12 PDT 2014

Brent Fulgham <bfulgham at webkit.org> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 133503: Enable WebGL on Windows

Attachment 232467: Patch

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=232467&action=review

I think this looks good. Can you fix the date on the file I reference in these
notes? r=me.

> Source/ThirdParty/ANGLE/include/EGL/eglsoftlinking.h:2
> + * Copyright (C) 2013 Apple Inc. All rights reserved.

Copyright 2014, please!

> Source/WebCore/html/canvas/WebGLRenderingContext.cpp:686
> +    if (isAccelerated() && renderBox &&
renderBox->hasAcceleratedCompositing()) {

Since the default case is for accelerated to be true, should this just be an

More information about the webkit-reviews mailing list