[webkit-reviews] review granted: [Bug 133510] [MediaStream] MediaStream.addTrack should not check for tracks ended state. : [Attachment 232476] MediaStream.addTrack should not check for tracks ended state.

Wed Jun 4 09:18:40 PDT 2014

Eric Carlson <eric.carlson at apple.com> has granted Kiran
<kiran.guduru at samsung.com>'s request for review:
Bug 133510: [MediaStream] MediaStream.addTrack should not check for tracks
ended state.
https://bugs.webkit.org/show_bug.cgi?id=133510

Attachment 232476: MediaStream.addTrack should not check for tracks ended
state.
https://bugs.webkit.org/attachment.cgi?id=232476&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=232476&action=review

If you address the comments, fill in the "Reviewed by" in each ChangeLog, and
upload the new patch WITHOUT orphaning the old version, you don't need another
review and any reviewer will mark it cq+.

> Source/WebCore/ChangeLog:14
> +	   (WebCore::MediaStreamPrivate::addTrack):

Nit: I think it is helpful to have a comment about what changed.

> LayoutTests/fast/mediastream/MediaStream-add-ended-tracks.html:1
> +<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">

Nit: you should use an HTML5 doctype here: "<!DOCTYPE html>"

> LayoutTests/fast/mediastream/MediaStream-add-ended-tracks.html:7
> +
> +

Nit: you have an extra blank line.

> LayoutTests/fast/mediastream/MediaStream-add-ended-tracks.html:10
> +

Ditto.

> LayoutTests/fast/mediastream/MediaStream-add-ended-tracks.html:41
> +

Ditto.

> LayoutTests/fast/mediastream/MediaStream-add-ended-tracks.html:50
> +

Ditto.