[webkit-reviews] review granted: [Bug 133198] SVG TextRuns do not always get RenderingContexts : [Attachment 232458] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 133198: SVG TextRuns do not always get RenderingContexts
https://bugs.webkit.org/show_bug.cgi?id=133198

Attachment 232458: Patch
https://bugs.webkit.org/attachment.cgi?id=232458&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=232458&action=review


> Source/WebCore/rendering/RenderThemeIOS.mm:573
> +    float maximumWidth = font.isSVGFont() ? 0 :
inputElement->locale().maximumWidthForDateType(dateType, font);

This deserves a FIXME comment referencing the bug you'll use to make things
work with SVG Fonts.

> LayoutTests/ChangeLog:12
> +	   * platform/ios-sim/fonts/resources/graffiti.svg: Added. SVG font for
above test.

Don't we already have an SVG font somewhere in LayoutTests?