[webkit-reviews] review granted: [Bug 133296] Need to check invalid scheme in navigator content utils : [Attachment 232415] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Gyuyoung Kim
<gyuyoung.kim at samsung.com>'s request for review:
Bug 133296: Need to check invalid scheme in navigator content utils
https://bugs.webkit.org/show_bug.cgi?id=133296

Attachment 232415: Patch
https://bugs.webkit.org/attachment.cgi?id=232415&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=232415&action=review


> Source/WebCore/ChangeLog:14
> +	   According to spec, scheme value should not contain a colon. So, this
cl checks if scheme contains a colon.
> +	   
> +	   "The scheme value, if it contains a colon (as in "mailto:"), will
never match anything, since schemes don't contain colons."
> +	   
> +	   Spec:
http://www.whatwg.org/specs/web-apps/current-work/#custom-handlers
> +
> +	   Blink back merge :
https://src.chromium.org/viewvc/blink?view=rev&revision=174748

This change log is peculiar, since this change has no effect on scheme validity
and the comments are not at all relevant to this change.

> Source/WebCore/ChangeLog:16
> +	   No new tests, covered by existing tests.

This is wrong. Please just omit this line.

> Source/WebCore/ChangeLog:19
> +	   * Modules/navigatorcontentutils/NavigatorContentUtils.cpp:
> +	   (WebCore::verifyProtocolHandlerScheme):

The changes to this file are OK, but they have nothing to do with this bug,
really. They are just formatting and comments changes.

> LayoutTests/ChangeLog:14
> +	   According to spec, scheme value should not contain a colon. So, this
cl checks if scheme contains a colon.
> +	   
> +	   "The scheme value, if it contains a colon (as in "mailto:"), will
never match anything, since schemes don't contain colons."
> +	   
> +	   Spec:
http://www.whatwg.org/specs/web-apps/current-work/#custom-handlers
> +
> +	   Blink back merge :
https://src.chromium.org/viewvc/blink?view=rev&revision=174748

This change log entry is really strange. It should just say:

    Add tests that check that schemes with colons in their names are rejected.