[webkit-reviews] review denied: [Bug 131515] Inlining native functions into the JavaScript in the FTL : [Attachment 232447] Native runtime library inlining in FTL for ftlopt branch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 3 16:08:15 PDT 2014


Filip Pizlo <fpizlo at apple.com> has denied Matthew Mirman <mmirman at apple.com>'s
request for review:
Bug 131515: Inlining native functions into the JavaScript in the FTL
https://bugs.webkit.org/show_bug.cgi?id=131515

Attachment 232447: Native runtime library inlining in FTL for ftlopt branch
https://bugs.webkit.org/attachment.cgi?id=232447&action=review

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=232447&action=review


> LayoutTests/js/regress/script-tests/ftl-library-inlining-dataview.js:13
> +    result = foo(new DataView(new ArrayBuffer(5)));

It would be far better to make this a result += foo..., so that your checking
incorporates results from runs 0 through 3999999 and not just the last run.

> LayoutTests/js/regress/script-tests/ftl-library-inlining-exceptions.js:15
> +    try { 
> +	   foo(i < count - 1000 ? new Date() : "a");
> +	   x = false;
> +    } catch (e) {
> +	   x = true;
> +    }

Ditto.	You could have a result that is computed by adding up the x's.

> LayoutTests/js/regress/script-tests/ftl-library-inlining-folding.js:14
> +    result = foo();

Ditto.


More information about the webkit-reviews mailing list