[webkit-reviews] review denied: [Bug 131515] Inlining native functions into the JavaScript in the FTL : [Attachment 232445] Native runtime library inlining in FTL for ftlopt branch

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has denied Matthew Mirman <mmirman at apple.com>'s
request for review:
Bug 131515: Inlining native functions into the JavaScript in the FTL
https://bugs.webkit.org/show_bug.cgi?id=131515

Attachment 232445: Native runtime library inlining in FTL for ftlopt branch
https://bugs.webkit.org/attachment.cgi?id=232445&action=review

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=232445&action=review


> LayoutTests/ChangeLog:13
> +	   * js/regress/script-tests/ftl-library-inlining.js: Added.
> +	   * js/regress/script-tests/ftl-library-inlining-dataview.js: Added.
> +	   * js/regress/script-tests/ftl-library-inlining-exceptions.js: Added.

> +	   * js/regress/script-tests/ftl-library-inlining-folding.js: Added.
> +	   * js/regress/script-tests/ftl-library-inlining-loops.js: Added.

These tests should check errors.

> Source/JavaScriptCore/runtime/BundlePath.h:34
> +const CString * bundlePath();

Change this to simply return const CString& or even just CString.  Or a const
char*.

Returning a const CString* is weird.