[webkit-reviews] review granted: [Bug 133471] Prepopulated tiles may never be unparented from TileGrids with aggressive tile retention on : [Attachment 232419] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 3 09:03:20 PDT 2014


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 133471: Prepopulated tiles may never be unparented from TileGrids with
aggressive tile retention on
https://bugs.webkit.org/show_bug.cgi?id=133471

Attachment 232419: patch
https://bugs.webkit.org/attachment.cgi?id=232419&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=232419&action=review


> Source/WebCore/platform/graphics/ca/mac/TileController.h:128
> +
> +

Blank lines.

> Source/WebCore/platform/graphics/ca/mac/TileGrid.h:125
> +    double timeUntilCohortExpires(TileCohortInfo cohortInfo); // move onto
cohortinfo?

const TileCohortInfo&. Could be static or moved onto TileCohortInfo.


More information about the webkit-reviews mailing list