[webkit-reviews] review granted: [Bug 133417] [iOS][WK2] Round the UIScrollView content size to device pixel : [Attachment 232401] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 2 15:04:39 PDT 2014


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 133417: [iOS][WK2] Round the UIScrollView content size to device pixel
https://bugs.webkit.org/show_bug.cgi?id=133417

Attachment 232401: Patch
https://bugs.webkit.org/attachment.cgi?id=232401&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=232401&action=review


> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:460
> +static CGSize roundScrollViewContentSize(const WebKit::WebPageProxy& page,
CGSize contentSize)

Why not just pass in page.deviceScaleFactor()?


More information about the webkit-reviews mailing list