[webkit-reviews] review granted: [Bug 133454] Update PlatformTimeRanges to use MediaTime rather than doubles for time values. : [Attachment 232397] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 133454: Update PlatformTimeRanges to use MediaTime rather than doubles for
time values.
https://bugs.webkit.org/show_bug.cgi?id=133454

Attachment 232397: Patch
https://bugs.webkit.org/attachment.cgi?id=232397&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=232397&action=review


> Source/WebCore/Modules/mediasource/SourceBuffer.cpp:1404
> +    MediaTime currentTime =
MediaTime::createWithDouble(m_source->currentTime());
>      const PlatformTimeRanges& ranges = m_buffered->ranges();
>      if (!ranges.length())
>	   return false;

Nit: no need to create "currentTime" if ranges is empty.

> Source/WebCore/platform/graphics/PlatformTimeRanges.h:74
> +	   Range(MediaTime start, MediaTime end)

Nit: any reason to not make these "const MediaTime&"?

> Source/WebCore/platform/graphics/PlatformTimeRanges.h:82
> +	   inline bool isPointInRange(MediaTime point) const

Ditto.