[webkit-reviews] review granted: [Bug 133445] [iOS] WebCore fails to build: platform/network/mac/ResourceHandleMac.mm:729:62: error: use of undeclared identifier '_CFURLConnectionCopyTimingData' : [Attachment 232377] Patch v1

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted David Kilzer (:ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 133445: [iOS] WebCore fails to build:
platform/network/mac/ResourceHandleMac.mm:729:62: error: use of undeclared
identifier '_CFURLConnectionCopyTimingData'
https://bugs.webkit.org/show_bug.cgi?id=133445

Attachment 232377: Patch v1
https://bugs.webkit.org/attachment.cgi?id=232377&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=232377&action=review


I don't understand this patch, what are the bots that fail? Everything was
building correctly for a long time.

r=meto fix the build anyway.

> Source/WebCore/platform/network/mac/ResourceHandleMac.mm:64
> +#else
> +typedef struct _CFURLConnection* CFURLConnectionRef;
> +extern "C" {
> +CFDictionaryRef _CFURLConnectionCopyTimingData(CFURLConnectionRef);
> +}
> +#endif

This shouldn't be an #else. We want to have the declarations even when the
private header is included, because this way, we will find out about changes in
SPIs sooner and more reliably. 

It's very difficult to debug issues caused by incorrect SPI declarations.

Also, this should be under #if USE(CFNETWORK), to match the code that uses
CFNetwork.