[webkit-reviews] review granted: [Bug 133436] Don't scroll to non-integral scroll offsets : [Attachment 232351] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 133436: Don't scroll to non-integral scroll offsets
https://bugs.webkit.org/show_bug.cgi?id=133436

Attachment 232351: Patch
https://bugs.webkit.org/attachment.cgi?id=232351&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=232351&action=review


>> Source/WebCore/page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm:325
>> +	FloatPoint roundedPosition(roundf(scrollPosition.x()),
roundf(scrollPosition.y()));
> 
> I am wondering whether the input devices that send integral values do integer
truncation or rounding. (and whether we should mimic that behavior)

Is this the single correct bottleneck for the rounding? What about the
setScrollPositionWithoutContentEdgeConstraints and setScrollLayerPosition
functions?