[webkit-reviews] review granted: [Bug 135488] [Media iOS] Ensure there is a nice default fallback for missing wireless target names : [Attachment 235868] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jul 31 21:44:47 PDT 2014
Eric Carlson <eric.carlson at apple.com> has granted Dean Jackson
<dino at apple.com>'s request for review:
Bug 135488: [Media iOS] Ensure there is a nice default fallback for missing
wireless target names
https://bugs.webkit.org/show_bug.cgi?id=135488
Attachment 235868: Patch
https://bugs.webkit.org/attachment.cgi?id=235868&action=review
------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=235868&action=review
> Source/WebCore/Modules/mediacontrols/mediaControlsiOS.js:113
> + var externalDeviceDisplayName =
(this.host.externalDeviceDisplayName && this.host.externalDeviceDisplayName !=
"") ? this.host.externalDeviceDisplayName : "AppleTV";
Nit: this would be slightly easier to understand if it was split into two
separate lines:
var externalDeviceDisplayName = this.host.externalDeviceDisplayName;
If (...)
More information about the webkit-reviews
mailing list