[webkit-reviews] review granted: [Bug 135478] [Win] Use RC_PROJECTBUILDVERSION as build portion of version : [Attachment 235854] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jul 31 16:42:17 PDT 2014
David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 135478: [Win] Use RC_PROJECTBUILDVERSION as build portion of version
https://bugs.webkit.org/show_bug.cgi?id=135478
Attachment 235854: Patch
https://bugs.webkit.org/attachment.cgi?id=235854&action=review
------- Additional Comments from David Kilzer (:ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=235854&action=review
r=me either way
Also, can we write a test for SAFE_BUILD_VERSION being defined in the
environment to test the override?
> WebKitLibraries/win/tools/scripts/version-stamp.pl:103
> +my $SAFE_BUILD_VERSION = $ENV{RC_PROJECTBUILDVERSION};
> +if (!defined($SAFE_BUILD_VERSION)) {
> + $SAFE_BUILD_VERSION = $components{'__VERSION_BUILD__'};
> +}
I would prefer to write this code thusly:
my $SAFE_BUILD_VERSION = $ENV{RC_PROJECTBUILDVERSION} ||
$components{'__VERSION_BUILD__'};
I think it's a lot easier to read that way. :)
More information about the webkit-reviews
mailing list