[webkit-reviews] review granted: [Bug 135451] PropertyName's internal string is always atomic. : [Attachment 235805] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Andreas Kling
<akling at apple.com>'s request for review:
Bug 135451: PropertyName's internal string is always atomic.
https://bugs.webkit.org/show_bug.cgi?id=135451

Attachment 235805: Patch
https://bugs.webkit.org/attachment.cgi?id=235805&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=235805&action=review


> Source/WebCore/bindings/js/JSHTMLDocumentCustom.cpp:57
> -    AtomicStringImpl* atomicPropertyName = findAtomicString(propertyName);
> +    AtomicStringImpl* atomicPropertyName = propertyName.publicName();
>      return atomicPropertyName &&
document->hasDocumentNamedItem(*atomicPropertyName);

Looks like another of those cases where we query a hash table multiple times to
access a property from JavaScript :(