[webkit-reviews] review granted: [Bug 135447] Default buttons do not pulse in OS X 10.10 : [Attachment 235797] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jul 30 19:01:26 PDT 2014
mitz at webkit.org <mitz at webkit.org> has granted Dean Jackson <dino at apple.com>'s
request for review:
Bug 135447: Default buttons do not pulse in OS X 10.10
https://bugs.webkit.org/show_bug.cgi?id=135447
Attachment 235797: Patch
https://bugs.webkit.org/attachment.cgi?id=235797&action=review
------- Additional Comments from mitz at webkit.org <mitz at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=235797&action=review
> Source/WebCore/rendering/RenderThemeMac.mm:2033
> +#if __MAC_OS_X_VERSION_MIN_REQUIRED < 101000
> + return true;
> +#else
> + return false;
> +#endif
We usually put the “present and future” case before the “legacy” case.
More information about the webkit-reviews
mailing list