[webkit-reviews] review granted: [Bug 135432] Web Inspector: console.profile missing profile information : [Attachment 235771] [PATCH] Proposed Fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 30 17:11:47 PDT 2014


Timothy Hatcher <timothy at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 135432: Web Inspector: console.profile missing profile information
https://bugs.webkit.org/show_bug.cgi?id=135432

Attachment 235771: [PATCH] Proposed Fix
https://bugs.webkit.org/attachment.cgi?id=235771&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=235771&action=review


> Source/WebCore/inspector/InspectorTimelineAgent.h:285
> +    int m_recordingProfileDepth;

ptrdiff_t! :)

Or size_t and just assert that m_recordingProfileDepth > 0 before
--m_recordingProfileDepth.


More information about the webkit-reviews mailing list