[webkit-reviews] review denied: [Bug 135414] Build warning in webkit/Source/JavaScriptCore/llint/LLIntSlowPaths.cpp : [Attachment 235738] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 30 05:53:46 PDT 2014


Mark Hahnenberg <mhahnenberg at apple.com> has denied Tanay
<tanay.c at samsung.com>'s request for review:
Bug 135414: Build warning in
webkit/Source/JavaScriptCore/llint/LLIntSlowPaths.cpp
https://bugs.webkit.org/show_bug.cgi?id=135414

Attachment 235738: Patch
https://bugs.webkit.org/attachment.cgi?id=235738&action=review

------- Additional Comments from Mark Hahnenberg <mhahnenberg at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=235738&action=review


> Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:1447
> +static JSObject* putToScopeCommon(ExecState* exec, Instruction* pc, VM&
/*vm*/)

You don't need to comment it out. Since it's not adding any useful information,
you can simply remove the parameter name entirely.


More information about the webkit-reviews mailing list