[webkit-reviews] review granted: [Bug 135399] Web Inspector: 80% of time during recording is spent creating source code locations for profile nodes : [Attachment 235732] [PATCH] Proposed Fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 29 22:10:36 PDT 2014


Timothy Hatcher <timothy at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 135399: Web Inspector: 80% of time during recording is spent creating
source code locations for profile nodes
https://bugs.webkit.org/show_bug.cgi?id=135399

Attachment 235732: [PATCH] Proposed Fix
https://bugs.webkit.org/attachment.cgi?id=235732&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=235732&action=review


> Source/WebInspectorUI/UserInterface/Models/ScriptTimelineRecord.js:281
> +    _initializeProfileFromPayload: function(payload)

As much as I hate leaking protocol data past the controllers into the model, I
this this is fine for the perf win.


More information about the webkit-reviews mailing list