[webkit-reviews] review granted: [Bug 135406] Web Inspector: Only compute full ProfileNode times if needed - Legacy Profiler : [Attachment 235727] [PATCH] Proposed Fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 29 20:37:57 PDT 2014


Timothy Hatcher <timothy at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 135406: Web Inspector: Only compute full ProfileNode times if needed -
Legacy Profiler
https://bugs.webkit.org/show_bug.cgi?id=135406

Attachment 235727: [PATCH] Proposed Fix
https://bugs.webkit.org/attachment.cgi?id=235727&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
There is no clients if these getters! It was just over engineering of the API
on my part before I added the time range computation. I see no harm keeping
them as lazy getters though.


More information about the webkit-reviews mailing list