[webkit-reviews] review granted: [Bug 135367] Web Inspector: ProbeSetDetailsSection should not create live location links for unresolved breakpoints : [Attachment 235708] Patch

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has granted Brian Burg
<burg at cs.washington.edu>'s request for review:
Bug 135367: Web Inspector: ProbeSetDetailsSection should not create live
location links for unresolved breakpoints
https://bugs.webkit.org/show_bug.cgi?id=135367

Attachment 235708: Patch
https://bugs.webkit.org/attachment.cgi?id=235708&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=235708&action=review


> Source/WebInspectorUI/UserInterface/Views/ProbeSetDetailsSection.js:98
> +	       var location = breakpoint.sourceCodeLocation;
> +	       titleElement = WebInspector.linkifyLocation(breakpoint.url,
location.displayLineNumber, location.displayColumnNumber);

This could use a comment. Maybe an assert that
breakpoint.sourceCodeLocation.sourceCode is null?