[webkit-reviews] review granted: [Bug 134140] Support for-in in the FTL : [Attachment 235655] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 29 13:32:39 PDT 2014


Filip Pizlo <fpizlo at apple.com> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 134140: Support for-in in the FTL
https://bugs.webkit.org/show_bug.cgi?id=134140

Attachment 235655: Patch
https://bugs.webkit.org/attachment.cgi?id=235655&action=review

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=235655&action=review


> Source/JavaScriptCore/ftl/FTLAbstractHeapRepository.h:79
> +    macro(Structure_structureID, Structure::structureIDOffset()) \
> +    macro(JSPropertyNameEnumerator_cachedStructureID,
JSPropertyNameEnumerator::cachedStructureIDOffset()) \
> +    macro(JSPropertyNameEnumerator_cachedInlineCapacity,
JSPropertyNameEnumerator::cachedInlineCapacityOffset()) \
> +    macro(JSPropertyNameEnumerator_cachedPropertyNamesLength,
JSPropertyNameEnumerator::cachedPropertyNamesLengthOffset()) \
> +    macro(JSPropertyNameEnumerator_cachedPropertyNamesVector,
JSPropertyNameEnumerator::cachedPropertyNamesVectorOffset())

Sort in alphabetical order.


More information about the webkit-reviews mailing list