[webkit-reviews] review granted: [Bug 135349] [CSS3-Text] Add rendering support for text-justify: none : [Attachment 235629] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Zoltan Horvath <zoltan at webkit.org>'s
request for review:
Bug 135349: [CSS3-Text] Add rendering support for text-justify: none
https://bugs.webkit.org/show_bug.cgi?id=135349

Attachment 235629: Patch
https://bugs.webkit.org/attachment.cgi?id=235629&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=235629&action=review


> Source/WebCore/rendering/RenderBlockLineLayout.cpp:681
> +	       if (textAlign == JUSTIFY && r != trailingSpaceRun
> +#if ENABLE(CSS3_TEXT)
> +		   && style().textJustify() != TextJustifyNone) {
> +#else
> +	       ) {
> +#endif

It’s better to not have repeated ) { characters to confuse code editors. How
about this instead?

		if (textAlign == JUSTIFY && r != trailingSpaceRun
    #if ENABLE(CSS3_TEXT)
		    && style().textJustify() != TextJustifyNone
    #endif
		) {

Does this really need to be done down here at such a low level? Can’t we change
the textAlign value at some higher level instead?