[webkit-reviews] review granted: [Bug 135368] [iOS WK2] WKWebView sometime tries to change the size of a null DrawingAreaProxy : [Attachment 235639] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jul 28 16:43:05 PDT 2014
Simon Fraser (smfr) <simon.fraser at apple.com> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 135368: [iOS WK2] WKWebView sometime tries to change the size of a null
DrawingAreaProxy
https://bugs.webkit.org/show_bug.cgi?id=135368
Attachment 235639: Patch
https://bugs.webkit.org/attachment.cgi?id=235639&action=review
------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=235639&action=review
> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:1354
> + if (WebKit::DrawingAreaProxy* drawingArea = _page->drawingArea())
Aren't we in the WebKit namespace here?
> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:2241
> + if (WebKit::DrawingAreaProxy* drawingArea = _page->drawingArea())
Ditto.
More information about the webkit-reviews
mailing list