[webkit-reviews] review denied: [Bug 135358] Create a more generic way for VMEntryScope to notify those interested that it will be destroyed : [Attachment 235635] patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has denied Saam Barati <sbarati at apple.com>'s
request for review:
Bug 135358: Create a more generic way for VMEntryScope to notify those
interested that it will be destroyed
https://bugs.webkit.org/show_bug.cgi?id=135358

Attachment 235635: patch 
https://bugs.webkit.org/attachment.cgi?id=235635&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=235635&action=review


> Source/JavaScriptCore/debugger/Debugger.cpp:338
> +	   VMEntryScope::EntryScopeDidPopListener callback = [this] (VM* vm,
JSGlobalObject* globalObject) 

This is probably a good place to use "auto".

> Source/JavaScriptCore/debugger/Debugger.cpp:341
> +	       if (globalObject->debugger() && globalObject->debugger() ==
this)
> +		   this->recompileAllJSFunctions(vm);

It feels weird to use 'this' here, since we can't guarantee its lifetime. I
think it would be better to use globalObject->debugger() instead of 'this'.