[webkit-reviews] review requested: [Bug 135358] Create a more generic way for VMEntryScope to notify those interested that it will be destroyed : [Attachment 235630] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jul 28 16:08:55 PDT 2014
Saam Barati <sbarati at apple.com> has asked for review:
Bug 135358: Create a more generic way for VMEntryScope to notify those
interested that it will be destroyed
https://bugs.webkit.org/show_bug.cgi?id=135358
Attachment 235630: patch
https://bugs.webkit.org/attachment.cgi?id=235630&action=review
------- Additional Comments from Saam Barati <sbarati at apple.com>
Currently, when VMEntryScope is destroyed, and it has a flag set that the VM
needs recompilation, it calls Debugger::recompileAllJSFunctions. This is
tailored specifically for the Debugger and its purposes of recompiling all
functions once the VM stops executing code (specifically, to ensure that there
are
no functions on the stack that will be clobbered by recompiling them). This
patch
will substitute this one recompilation flag with a list of callbacks that are
all
notified when the VMEntryScope dies. This creates a more generalized interface
to
being notified when the VM stops executing code via the event of VMEntryScope
dying.
More information about the webkit-reviews
mailing list