[webkit-reviews] review granted: [Bug 135361] REGRESSION(r164133): Selection disappears after scrolling on nytimes.com : [Attachment 235626] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 28 16:03:40 PDT 2014


Ryosuke Niwa <rniwa at webkit.org> has granted Zalan Bujtas <zalan at apple.com>'s
request for review:
Bug 135361: REGRESSION(r164133): Selection disappears after scrolling on
nytimes.com
https://bugs.webkit.org/show_bug.cgi?id=135361

Attachment 235626: Patch
https://bugs.webkit.org/attachment.cgi?id=235626&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=235626&action=review


>
LayoutTests/fast/dynamic/selection-gets-cleared-when-part-of-it-gets-removed-ex
pected.html:3
> +  <title>This tests that selection stays on when part of the selection gets
removed.</title>

Nit: wrong indentations!
Ditto elsewhere in the file.

>
LayoutTests/fast/dynamic/selection-gets-cleared-when-part-of-it-gets-removed.ht
ml:3
> +  <title>This tests that selection stays on when part of the selection gets
removed.</title>

Nit: wrong indentations!
Ditto elsewhere in the file.

>
LayoutTests/fast/dynamic/selection-gets-cleared-when-part-of-it-gets-removed.ht
ml:15
> +    

Nit: whitespaces.

>
LayoutTests/fast/dynamic/selection-gets-cleared-when-part-of-it-gets-removed.ht
ml:21
> +    

Nit: whitespaces.


More information about the webkit-reviews mailing list