[webkit-reviews] review granted: [Bug 135332] [Mac, iOS] Paint-on closed captions get out-of-order in Safari : [Attachment 235596] Re-Upload to allow EWS runs

[bugzilla-daemon at webkit.org]

Jer Noble <jer.noble at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 135332: [Mac, iOS] Paint-on closed captions get out-of-order in Safari
https://bugs.webkit.org/show_bug.cgi?id=135332

Attachment 235596: Re-Upload to allow EWS runs
https://bugs.webkit.org/attachment.cgi?id=235596&action=review

------- Additional Comments from Jer Noble <jer.noble at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=235596&action=review


>> Source/WebCore/html/track/TextTrackCue.cpp:203
>> +	    return startTime() > other->startTime();
> 
> I'm not sure if this should just be in TextTrackCueGeneric. If it is, we have
to bypass calling into this base class entirely, because the base class will
return early with 'true' for roll-up cases that we need to treat as 'false'.

Yes, I think this would be best put into the Generic class.  Other than that,
r+.