[webkit-reviews] review granted: [Bug 135344] REGRESSION (r160806): CSS zoom property doesn't work on anything inside anchors. : [Attachment 235604] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Andreas Kling
<akling at apple.com>'s request for review:
Bug 135344: REGRESSION (r160806): CSS zoom property doesn't work on anything
inside anchors.
https://bugs.webkit.org/show_bug.cgi?id=135344

Attachment 235604: Patch
https://bugs.webkit.org/attachment.cgi?id=235604&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=235604&action=review


> Source/WebCore/rendering/style/RenderStyle.h:2087
>  {
> +    setEffectiveZoom(effectiveZoom() * f);
>      if (compareEqual(visual->m_zoom, f))
>	   return false;
>      visual.access()->m_zoom = f;
> -    setEffectiveZoom(effectiveZoom() * zoom());
>      return true;

Would be nice to rename "f" to something understandable.