[webkit-reviews] review granted: [Bug 135343] Web Replay: auto-decoding of parameterized vector's elements is incorrect : [Attachment 235602] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 28 11:49:12 PDT 2014


Timothy Hatcher <timothy at apple.com> has granted Brian Burg
<burg at cs.washington.edu>'s request for review:
Bug 135343: Web Replay: auto-decoding of parameterized vector's elements is
incorrect
https://bugs.webkit.org/show_bug.cgi?id=135343

Attachment 235602: Patch
https://bugs.webkit.org/attachment.cgi?id=235602&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=235602&action=review


>
Source/JavaScriptCore/replay/scripts/tests/expected/generate-input-with-vector-
members.json-TestReplayInputs.cpp:61
> +SavedHistory::~SavedHistory()
> +{
> +}
>  } // namespace Test

A newline before the namespace close would be nice.

>
Source/JavaScriptCore/replay/scripts/tests/expected/generate-input-with-vector-
members.json-TestReplayInputs.h:91
> +};
>  } // namespace Test

Ditto.


More information about the webkit-reviews mailing list