[webkit-reviews] review granted: [Bug 135287] BuildFix: JavaScriptCore/bytecode/StructureSet.h:262:77: warning : [Attachment 235514] patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Tamas Gergely
<tgergely.u-szeged at partner.samsung.com>'s request for review:
Bug 135287: BuildFix: JavaScriptCore/bytecode/StructureSet.h:262:77: warning
https://bugs.webkit.org/show_bug.cgi?id=135287

Attachment 235514: patch
https://bugs.webkit.org/attachment.cgi?id=235514&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=235514&action=review


I think the new version of StructureSet was rolled out of the tree; this patch
isn’t relevant until we bring it back in.

Best would be to make sure Filip fixes this before he re-lands the new code.

> Source/JavaScriptCore/bytecode/StructureSet.h:43
> +	   : m_pointer(0)

Please use nullptr.

> Source/JavaScriptCore/bytecode/StructureSet.h:49
> +	   : m_pointer(0)

Please use nullptr.

> Source/JavaScriptCore/bytecode/StructureSet.h:55
> +	   : m_pointer(0)

Not sure it’s needed in this case. I didn’t carefully study copyFrom, but I
don’t think it uses the old m_pointer value.