[webkit-reviews] review granted: [Bug 135329] Don't rely on reading applicationState from within DidEnterBackground/WillEnterForeground : [Attachment 235584] Fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jul 27 16:23:03 PDT 2014


Sam Weinig <sam at webkit.org> has granted Gavin Barraclough
<barraclough at apple.com>'s request for review:
Bug 135329: Don't rely on reading applicationState from within
DidEnterBackground/WillEnterForeground
https://bugs.webkit.org/show_bug.cgi?id=135329

Attachment 235584: Fix
https://bugs.webkit.org/attachment.cgi?id=235584&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=235584&action=review


> Source/WebKit2/UIProcess/ios/ProcessAssertionIOS.mm:106
> +    _appIsBackground = FALSE;

Please use NO.

> Source/WebKit2/UIProcess/ios/ProcessAssertionIOS.mm:112
> +    _appIsBackground = TRUE;

Please use YES.


More information about the webkit-reviews mailing list