[webkit-reviews] review denied: [Bug 135328] [WK2] Crash when accessing window.localStorage after calling window.close() : [Attachment 235583] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has denied Daniel Bates <dbates at webkit.org>'s
request for review:
Bug 135328: [WK2] Crash when accessing window.localStorage after calling
window.close()
https://bugs.webkit.org/show_bug.cgi?id=135328

Attachment 235583: Patch
https://bugs.webkit.org/attachment.cgi?id=235583&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=235583&action=review


> Source/WebCore/page/Page.h:329
> +    bool willCloseWindowSoon() const { return m_willCloseWindowSoon &&
isInWindow(); }

Does this work for background tabs? I'm not clear on what the isInWindow() case
is trying to achieve.

> Source/WebCore/page/Page.h:597
> +    bool m_willCloseWindowSoon;

I think a better name would be something along the lines of m_isClosing.