[webkit-reviews] review canceled: [Bug 135313] Web Inspector: Timelines performance is very slow, has many forced layouts : [Attachment 235555] [PATCH] Proposed Fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 25 20:07:56 PDT 2014


Joseph Pecoraro <joepeck at webkit.org> has canceled Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 135313: Web Inspector: Timelines performance is very slow, has many forced
layouts
https://bugs.webkit.org/show_bug.cgi?id=135313

Attachment 235555: [PATCH] Proposed Fix
https://bugs.webkit.org/attachment.cgi?id=235555&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
Better. It turns out showEmptyPlaceholder could also benefit from the early
return if nothing changed. This is another huge win if the time range selection
doesn't start at 0.0. Otherwise we would have hit the same forced layout loop
calling this over and over. Note, the messages is always the same so maybe we
can simplify this a bit more.


More information about the webkit-reviews mailing list