[webkit-reviews] review granted: [Bug 135310] Parent fullscreen from window instead of view : [Attachment 235551] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jul 25 16:36:44 PDT 2014
Jer Noble <jer.noble at apple.com> has granted Jeremy Jones
<jeremyj-wk at apple.com>'s request for review:
Bug 135310: Parent fullscreen from window instead of view
https://bugs.webkit.org/show_bug.cgi?id=135310
Attachment 235551: Patch
https://bugs.webkit.org/attachment.cgi?id=235551&action=review
------- Additional Comments from Jer Noble <jer.noble at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=235551&action=review
> Source/WebKit/mac/ChangeLog:7
> + Reviewed by NOBODY (OOPS!).
> +
This and...
> Source/WebKit2/ChangeLog:7
> + Reviewed by NOBODY (OOPS!).
> +
...this could use an explanation about why switching from view-parented to
window-parented fixes the rotation problem.
Other than that, looks good.
More information about the webkit-reviews
mailing list