[webkit-reviews] review granted: [Bug 135291] [MSE] Playback stalls & readyState drops to HAVE_CURRENT_DATA at end of stream with unbalanced buffered SourceBuffers : [Attachment 235539] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Jer Noble <jer.noble at apple.com>'s
request for review:
Bug 135291: [MSE] Playback stalls & readyState drops to HAVE_CURRENT_DATA at
end of stream with unbalanced buffered SourceBuffers
https://bugs.webkit.org/show_bug.cgi?id=135291

Attachment 235539: Patch
https://bugs.webkit.org/attachment.cgi?id=235539&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=235539&action=review


> Source/WebCore/ChangeLog:3
> +	   [MSE] Playback stalls & readyState drops to HAVE_CURRENT_DATA at end
of stream with unbalanced buffered SourceBuffers

Please add the radar for future Sam's sake and also change the title to explain
why this is important (aka Youtube is broken).

> Source/WebCore/platform/graphics/PlatformTimeRanges.h:54
>  
> +    MediaTime start(unsigned index) const;
>      MediaTime start(unsigned index, bool& valid) const;
> +    MediaTime end(unsigned index) const;
>      MediaTime end(unsigned index, bool& valid) const;
> +    MediaTime duration(unsigned index) const;
> +    MediaTime maximumBufferedTime() const;

You don't have to do this now, but you should eventually switch these to return
Optional<MediaTime> if they can fail.